Animations disabling refactors #30653
Merged
+160
−221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a common function we can use to determine whether animations are disabled globally. This reduces duplication and makes it easier to change the logic.
crisbeto
added
target: major
crisbeto
requested review from
andrewseguin and
mmalerba
and removed request for
a team
Currently the CDK overlay uses `ANIMATION_MODULE_TYPE` to implicitly disable the backdrop animation, however we want to introduce a Material-specific way of disabling animations. These changes add a config option that we can use to do so.
crisbeto
force-pushed
the
consolidate-animations-disabled
branch
from
f8e01aa to
371be9e
Compare
andrewseguin
approved these changes
Mar 19, 2025
mmalerba
approved these changes
Mar 19, 2025
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a couple of refactors in the direction of allowing us to introduce a custom DI token for controlling Material animations:
refactor(multiple): consolidate logic for disabling animations
Adds a common function we can use to determine whether animations are disabled globally. This reduces duplication and makes it easier to change the logic.
refactor(cdk/overlay): add config option for disabling animations
Currently the CDK overlay uses
ANIMATION_MODULE_TYPEto implicitly disable the backdrop animation, however we want to introduce a Material-specific way of disabling animations. These changes add a config option that we can use to do so.